Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes StatefulSet support is easiest when pulling the broker id out of the hostname pattern
$HOSTNAME="kafka-1" should be broker-id 1
So the start.sh script pulls that out of there with
sed. If you set$KAFKA_BROKER_IDbeforestart.shruns, it'll honor that value.I upgraded the server.properties.template with the latest from the kafka tar.gz, backporting the config vars and pruning deprecated ones:
advertised.host.name/advertised.portauto.leader.rebalance.enableis true by default, don't need it in config fileLOG_FLUSH_SCHEDULER_INTERVAL_MSso folks can actually flush data (I had huge recheck times on reboot)ZOOKEEPER_CONNECTION_STRINGandZOOKEEPER_CHROOTare not compatible if specifying multiple ZK hosts to connect to. RemovingZK_CHROOTand updating documentation to show that can be rolled in to connection string.KAFKA_PORThas been rolled in to thelisteners/advertised.listenersconfig. Removing from ENV and documenting how to override in docker command.